kgyrtkirk commented on PR #15694: URL: https://github.com/apache/druid/pull/15694#issuecomment-1934287251
its kinda the same what we had in the original PR; but the impact of this highly depends on the number of constants at play....and although it has performance benefits - it really just reduces the amount of garbage being created and by that it even reduces the error of the execution times I've done the following runs: * `current-master` - baseline at [this commit](https://github.com/apache/druid/commit/f3996b96ffdf13f49de9fc7273e0643a90dd7032) (all other branches were merged with this commit) * `fix-eval-thread-safety` - the `singleThreaded()` approach #15694 * `fix-eval-thread-safety-5` - the more conservative fix of #15743 * `expr-full-revert` - the full revert of the original patch I always wanted to look into what tools are available to compare jmh results - the ui I've found is not really designed to compare 4 results...but I think its usable: * [compare all](https://jmh.morethan.io/?sources=https://gist.githubusercontent.com/kgyrtkirk/e63c6a5ac5695ea821c6b7e22cbe4480/raw/f212ea8b3f36fdae12b6bbacb87238b3909ca8d3/out.current-master.jar.json,https://gist.githubusercontent.com/kgyrtkirk/b2f49ffbd4cd405488241f2ac5e5e235/raw/431c0e9b95822d2db53e415632fc999890a4f6bb/out.fix-eval-thread-safety.jar.json,https://gist.githubusercontent.com/kgyrtkirk/20142c0dc0f81b65f7a1f93279e9f1b8/raw/923f44897b237bce893dbbd7d03dac2cfb53aa6b/out.fix-eval-thread-safety-5.jar.json,https://gist.githubusercontent.com/kgyrtkirk/8fdd4744b0fcc1a81f3f6cba8e582297/raw/122c1b62a694aec54506a098ec492b622d330069/out.expr-full-revert.jar.json) * [compare alternate approaches](https://jmh.morethan.io/?sources=https://gist.githubusercontent.com/kgyrtkirk/b2f49ffbd4cd405488241f2ac5e5e235/raw/431c0e9b95822d2db53e415632fc999890a4f6bb/out.fix-eval-thread-safety.jar.json,https://gist.githubusercontent.com/kgyrtkirk/20142c0dc0f81b65f7a1f93279e9f1b8/raw/923f44897b237bce893dbbd7d03dac2cfb53aa6b/out.fix-eval-thread-safety-5.jar.json) * [compare current_master and this PR](https://jmh.morethan.io/?sources=https://gist.githubusercontent.com/kgyrtkirk/e63c6a5ac5695ea821c6b7e22cbe4480/raw/f212ea8b3f36fdae12b6bbacb87238b3909ca8d3/out.current-master.jar.json,https://gist.githubusercontent.com/kgyrtkirk/b2f49ffbd4cd405488241f2ac5e5e235/raw/431c0e9b95822d2db53e415632fc999890a4f6bb/out.fix-eval-thread-safety.jar.json) * [compare reverted vs alternated PR](https://jmh.morethan.io/?sources=https://gist.githubusercontent.com/kgyrtkirk/8fdd4744b0fcc1a81f3f6cba8e582297/raw/122c1b62a694aec54506a098ec492b622d330069/out.expr-full-revert.jar.json,https://gist.githubusercontent.com/kgyrtkirk/20142c0dc0f81b65f7a1f93279e9f1b8/raw/923f44897b237bce893dbbd7d03dac2cfb53aa6b/out.fix-eval-thread-safety-5.jar.json) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
