kgyrtkirk commented on PR #15694: URL: https://github.com/apache/druid/pull/15694#issuecomment-1973773244
I've made some minor changes the way this single threaded version is created/supported by exprs. Before replying on perf/etc I wanted to see how a more convoluted case performs: I've added a case statement with a 100 branches. The results are not that different from earlier ones: * It performs around 10% better for these expressions * Measurement error is reduced because it reduces GC pressure. * I remember a bit more relevant differences for a real query, but never digged into very deeply [revert Vs this branch](https://jmh.morethan.io/?sources=https://gist.githubusercontent.com/kgyrtkirk/8bf6805deda22f6dddc25c6e0e16d3b1/raw/3cdc3bcf88481030ef48ebab9b542e7979e56ead/out.expr-full-revert.jar.json,https://gist.githubusercontent.com/kgyrtkirk/e3826bf1a99993ad990e86acb29438ad/raw/4434bb34ea9fc2e03539a383451309a4d0eaecc5/out.fix-eval-thread-safety.jar.json) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
