kfaraz commented on code in PR #15706:
URL: https://github.com/apache/druid/pull/15706#discussion_r1484110714
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java:
##########
@@ -538,10 +538,9 @@ List<CoordinatorDuty> makeIndexingServiceDuties()
if (getCompactSegmentsDutyFromCustomGroups().isEmpty()) {
duties.add(compactSegments);
}
- log.debug(
- "Initialized indexing service duties [%s].",
- duties.stream().map(duty ->
duty.getClass().getName()).collect(Collectors.toList())
- );
+ if (log.isDebugEnabled()) {
+ log.debug("Initialized indexing service duties [%s].",
duties.stream().map(duty ->
duty.getClass().getName()).collect(Collectors.toList()));
Review Comment:
This one was better broken up across multiple lines. It seems difficult to
read now.
##########
processing/src/main/java/org/apache/druid/java/util/common/io/smoosh/FileSmoosher.java:
##########
@@ -490,11 +490,9 @@ public boolean isOpen()
public void close() throws IOException
{
closer.close();
- FileSmoosher.LOG.debug(
- "Created smoosh file [%s] of size [%s] bytes.",
- outFile.getAbsolutePath(),
- outFile.length()
- );
+ if (LOG.isDebugEnabled()) {
+ FileSmoosher.LOG.debug("Created smoosh file [%s] of size [%s] bytes.",
outFile.getAbsolutePath(), outFile.length());
Review Comment:
```suggestion
LOG.debug("Created smoosh file [%s] of size [%s] bytes.",
outFile.getAbsolutePath(), outFile.length());
```
##########
server/src/main/java/org/apache/druid/server/coordinator/loading/CuratorLoadQueuePeon.java:
##########
@@ -230,12 +230,9 @@ public void run()
final String path = ZKPaths.makePath(basePath,
segmentHolder.getSegmentIdentifier());
final byte[] payload =
jsonMapper.writeValueAsBytes(segmentHolder.getChangeRequest());
curator.create().withMode(CreateMode.EPHEMERAL).forPath(path, payload);
- log.debug(
- "ZKNode created for server to [%s] %s [%s]",
- basePath,
- segmentHolder.getAction(),
- segmentHolder.getSegmentIdentifier()
- );
+ if (log.isDebugEnabled()) {
+ log.debug("ZKNode created for server to [%s] %s [%s]", basePath,
segmentHolder.getAction(), segmentHolder.getSegmentIdentifier());
Review Comment:
Nit: Line is too long.
```suggestion
log.debug(
"ZKNode created for server to [%s] %s [%s]",
basePath, segmentHolder.getAction(),
segmentHolder.getSegmentIdentifier()
);
```
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScaler.java:
##########
@@ -149,7 +149,9 @@ private Runnable computeAndCollectLag()
long totalLags = lagStats.getTotalLag();
lagMetricsQueue.offer(totalLags > 0 ? totalLags : 0L);
}
- log.debug("Current lags [%s] for dataSource [%s].", new
ArrayList<>(lagMetricsQueue), dataSource);
+ if (log.isDebugEnabled()) {
+ log.debug("Current lags [%s] for dataSource [%s].", new
ArrayList<>(lagMetricsQueue), dataSource);
+ }
Review Comment:
Sorry I had missed this in the first review.
We can simplify this as follows:
```suggestion
log.debug("Current lags [%s] for dataSource [%s].",
lagMetricsQueue, dataSource);
```
`CircularFifoQueue.toString` and `ArrayList.toString` would return the same
string, so no point converting to list.
##########
server/src/main/java/org/apache/druid/discovery/DataServerClient.java:
##########
@@ -91,7 +91,9 @@ public <T> Sequence<T> run(Query<T> query, ResponseContext
responseContext, Java
requestBuilder = requestBuilder.jsonContent(objectMapper, query);
}
- log.debug("Sending request to servers for query[%s], request[%s]",
query.getId(), requestBuilder.toString());
+ if (log.isDebugEnabled()) {
+ log.debug("Sending request to servers for query[%s], request[%s]",
query.getId(), requestBuilder.toString());
+ }
Review Comment:
```suggestion
if (log.isDebugEnabled()) {
log.debug("Sending request to servers for query[%s], request[%s]",
query.getId(), requestBuilder);
}
```
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScaler.java:
##########
@@ -149,7 +149,9 @@ private Runnable computeAndCollectLag()
long totalLags = lagStats.getTotalLag();
lagMetricsQueue.offer(totalLags > 0 ? totalLags : 0L);
}
- log.debug("Current lags [%s] for dataSource [%s].", new
ArrayList<>(lagMetricsQueue), dataSource);
+ if (log.isDebugEnabled()) {
+ log.debug("Current lags [%s] for dataSource [%s].", new
ArrayList<>(lagMetricsQueue), dataSource);
+ }
Review Comment:
This might also help further with the coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
