kfaraz commented on code in PR #15706:
URL: https://github.com/apache/druid/pull/15706#discussion_r1484110714


##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java:
##########
@@ -538,10 +538,9 @@ List<CoordinatorDuty> makeIndexingServiceDuties()
     if (getCompactSegmentsDutyFromCustomGroups().isEmpty()) {
       duties.add(compactSegments);
     }
-    log.debug(
-        "Initialized indexing service duties [%s].",
-        duties.stream().map(duty -> 
duty.getClass().getName()).collect(Collectors.toList())
-    );
+    if (log.isDebugEnabled()) {
+      log.debug("Initialized indexing service duties [%s].", 
duties.stream().map(duty -> 
duty.getClass().getName()).collect(Collectors.toList()));

Review Comment:
   This one was better broken up across multiple lines. It seems difficult to 
read now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to