LakshSingla opened a new pull request, #15917:
URL: https://github.com/apache/druid/pull/15917
### Description
This PR adds support for numeric arrays for columnar frame types. Columnar
frame types are used in window functions processing and materializing subquery
results, therefore it fixes up a major hole in the current capabilities of
those.
### Layout of the column
For storing a column of n rows, it is laid out in the following fashion.
Assume that the total number of the elements (i.e. individual values in the
array) in all the rows combined is k:
| Section | Length of the section | Value |
|--------|--------|--------|
| | 0 | Type info, representing the column type |
| 1 | `n * Integer.BYTES` | n integers, where i-th integer represents
cumulative row length |
| 2 | `k * Byte.BYTES` | k bytes, where i-th byte represent whether the k-th
value (from the start is null) |
| 3 | `k * ELEMENT_SIZE` | k values, each representing the element, or null
equivalent value (e.g 0 for double) |
#### Release note
Columnar frames used in subquery materialization and window functions now
support numeric arrays.
<hr>
##### Key changed/added classes in this PR
* `MyFoo`
* `OurBar`
* `TheirBaz`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
