zachjsh commented on code in PR #15908:
URL: https://github.com/apache/druid/pull/15908#discussion_r1492918391
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/IngestHandler.java:
##########
@@ -180,9 +157,24 @@ public void validate()
operationName()
);
}
+ DruidSqlIngest ingestNode = ingestNode();
Review Comment:
removed duplicate validation.
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/IngestHandler.java:
##########
@@ -299,13 +291,42 @@ public InsertHandler(
SqlExplain explain
)
{
- super(
- handlerContext,
- sqlNode,
- convertQuery(sqlNode),
- explain
- );
- this.sqlNode = sqlNode;
+ super(handlerContext, explain);
+ this.sqlNode = convertQuery(sqlNode);
+ handlerContext.hook().captureInsert(sqlNode);
+ }
+
+ protected static DruidSqlInsert convertQuery(DruidSqlIngest sqlNode)
+ {
+ SqlNode query = sqlNode.getSource();
+
+ // Check if ORDER BY clause is not provided to the underlying query
+ if (query instanceof SqlOrderBy) {
Review Comment:
refactored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
