abhishekrb19 commented on PR #15941: URL: https://github.com/apache/druid/pull/15941#issuecomment-1960738053
Thanks for the review, @kfaraz! I've addressed your comments and kept the new metric along with other minor functional changes in this patch. But let me know if you'd prefer to keep the changes separate. Re the NPE fix, my bad, it was from existing test code --`TestSegmentsMetadataManager` was returning null instead of an empty set for `retrieveAllDataSourceNames()`. Removed that from the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
