abhishekrb19 commented on code in PR #15941:
URL: https://github.com/apache/druid/pull/15941#discussion_r1501755337


##########
docs/operations/metrics.md:
##########
@@ -342,6 +342,7 @@ These metrics are for the Druid Coordinator and are reset 
each time the Coordina
 |`killTask/availableSlot/count`| Number of available task slots that can be 
used for auto kill tasks in the auto kill run. This is the max number of task 
slots minus any currently running auto kill tasks.                              
                                                                                
                                                                                
                                                                                
                                       | |Varies|
 |`killTask/maxSlot/count`| Maximum number of task slots available for auto 
kill tasks in the auto kill run.                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                | |Varies|
 |`kill/task/count`| Number of tasks issued in the auto kill run.               
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                     | |Varies|
+|`kill/candidateUnusedSegments/count`|Number of candidate unused segments to 
be deleted from the metadata store in an auto kill run.|`dataSource`|Varies|

Review Comment:
   > Is it the number of segments that the coordinator decided to kill in a 
datasource or the number of segments that should be killed in a datasource? 
   
   It's the latter - clarified the docs a wee bit. Let me know if you have a 
better suggestion. I called it candidate because it's ultimately the underlying 
kill task that can say this for sure.
   
   >Also, should it have interval as a dimension?
   
   No, there can be multiple intervals.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to