pranavbhole commented on PR #15999: URL: https://github.com/apache/druid/pull/15999#issuecomment-1970196429
need to fix tests: "notanumber" is now 0.0 instead of 0 which should fine i guess. `Error: org.apache.druid.data.input.impl.RowsTest.test_objectToNumber_typeDouble_noThrow Error: Run 1: RowsTest.test_objectToNumber_typeDouble_noThrow:224 notanumber (nothrow) expected:<0> but was:<0.0> [INFO] Error: org.apache.druid.data.input.impl.RowsTest.test_objectToNumber_typeFloat_noThrow Error: Run 1: RowsTest.test_objectToNumber_typeFloat_noThrow:189 notanumber (nothrow) expected:<0> but was:<0.0> ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
