kgyrtkirk opened a new pull request, #16010:
URL: https://github.com/apache/druid/pull/16010
* prioritize the last added matcher in DruidExceptionMatcher
* it adds quite a few matchers and the most interesting one which checks
the messages is at the end; showing the message could give better detail about
what went wrong (instead of Person mismatch)
* this made 2 more tests pass
* remove smart defaulting to some QUERY_CONTEXT values in case they are not
supplied
* there are tests which do rely on some context values set - especially
the ones which use the timestamp
* it also made it unnecessary to explain in long comments why something is
happening
* add some basic report generator for not-yet-supported annotated things
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
