gianm commented on code in PR #15743:
URL: https://github.com/apache/druid/pull/15743#discussion_r1509460475
##########
processing/src/main/java/org/apache/druid/math/expr/ConstantExpr.java:
##########
@@ -39,9 +40,12 @@
* {@link Expr.ObjectBinding}. {@link ConstantExpr} are terminal nodes of an
expression tree, and have no children
* {@link Expr}.
*/
+@Immutable
abstract class ConstantExpr<T> implements Expr
{
final ExpressionType outputType;
+
+ @SuppressWarnings("Immutable")
Review Comment:
Ah, it's an errorprone thing? Cool. I was just wondering. I don't think we
should necessarily aggressively use it everywhere (we have a lot of immutable
classes, seems like it would be a lot of annotation noise) but it seems useful
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
