zachjsh commented on code in PR #15994:
URL: https://github.com/apache/druid/pull/15994#discussion_r1509525944
##########
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java:
##########
@@ -133,18 +137,20 @@ Collection<DataSegment> retrieveUsedSegmentsForIntervals(
*
* @param dataSource The data source the segments belong to
* @param interval Filter the data segments to ones that include data in
this interval exclusively.
+ * @param version An optional version of segments to retrieve in the
given {@code interval}. If unspecified, all
+ * versions of unused segments in the {@code interval}
must be retrieved.
* @param limit The maximum number of unused segments to retreive. If null,
no limit is applied.
* @param maxUsedStatusLastUpdatedTime The maximum {@code
used_status_last_updated} time. Any unused segment in {@code interval}
- * with {@code used_status_last_updated}
no later than this time will be included in the
- * kill task. Segments without {@code
used_status_last_updated} time (due to an upgrade
- * from legacy Druid) will have {@code
maxUsedStatusLastUpdatedTime} ignored
- *
+ * with {@code used_status_last_updated}
no later than this time will be included in the
+ * kill task. Segments without {@code
used_status_last_updated} time (due to an upgrade
+ * from legacy Druid) will have {@code
maxUsedStatusLastUpdatedTime} ignored
* @return DataSegments which include ONLY data within the requested
interval and are marked as unused. Segments NOT
* returned here may include data in the interval
*/
List<DataSegment> retrieveUnusedSegmentsForInterval(
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
