abhishekrb19 commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1515514934
########## server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java: ########## @@ -124,6 +127,7 @@ default Collection<DataSegment> retrieveUsedSegmentsForInterval( Collection<DataSegment> retrieveUsedSegmentsForIntervals( Review Comment: They are only used by the overlord. The interface allows tests to have custom implementations as needed. Also, the new nullable `version` parameter shouldn't cause any issues with rolling upgrade and downgrade situations. @kfaraz, could you please spot check this assumption? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
