YongGang commented on code in PR #16025:
URL: https://github.com/apache/druid/pull/16025#discussion_r1510388205
##########
server/src/main/java/org/apache/druid/server/metrics/MetricsModule.java:
##########
@@ -210,4 +210,11 @@ public OshiSysMonitor
getOshiSysMonitor(DataSourceTaskIdHolder dataSourceTaskIdH
return new OshiSysMonitor(dimensions);
}
}
+
+ @Provides
+ @ManageLifecycle
+ public ServiceStatusMonitor getServiceStatusMonitor()
Review Comment:
In several services (Coordinator, MiddleManager, Peon, Overlord),
`ServiceStatusMonitor` is already bound. Here, in the Metrics module, it’s
explicitly bound again. We need to verify if this explicit binding overrides
the existing bindings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
