arunramani commented on code in PR #16025:
URL: https://github.com/apache/druid/pull/16025#discussion_r1513373313
##########
server/src/main/java/org/apache/druid/server/metrics/MetricsModule.java:
##########
@@ -210,4 +210,11 @@ public OshiSysMonitor
getOshiSysMonitor(DataSourceTaskIdHolder dataSourceTaskIdH
return new OshiSysMonitor(dimensions);
}
}
+
+ @Provides
+ @ManageLifecycle
+ public ServiceStatusMonitor getServiceStatusMonitor()
Review Comment:
The bindings seem to be singleton so I don't think it's overriding or
double-injecting. For example the logs aren't showing 2 heartbeats being
emitted. Let me know if there's another place I could be checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
