abhishekrb19 commented on code in PR #16031:
URL: https://github.com/apache/druid/pull/16031#discussion_r1511091259
##########
docs/querying/sql-translation.md:
##########
@@ -71,7 +71,7 @@ EXPLAIN PLAN statements return:
- a `RESOURCES` column that describes the resources used in the query
- an `ATTRIBUTES` column that describes the attributes of the query, including:
- `statementType`: the SQL statement type
- - `targetDataSource`: the target datasource in an INSERT or REPLACE statement
+ - `targetDataSource`: a JSON object representing the target datasource in an
INSERT or REPLACE statement.
Review Comment:
```suggestion
- `targetDataSource`: a JSON object representing the target datasource in
an INSERT or REPLACE statement
```
##########
docs/querying/sql-translation.md:
##########
@@ -71,7 +71,7 @@ EXPLAIN PLAN statements return:
- a `RESOURCES` column that describes the resources used in the query
- an `ATTRIBUTES` column that describes the attributes of the query, including:
- `statementType`: the SQL statement type
- - `targetDataSource`: the target datasource in an INSERT or REPLACE statement
+ - `targetDataSource`: a JSON object representing the target datasource in an
INSERT or REPLACE statement.
- `partitionedBy`: the time-based partitioning granularity in an INSERT or
REPLACE statement
Review Comment:
For 29.0.0, could you also please update `targetDataSource` format in this
doc to the JSON object in these example `EXPLAIN PLAN` outputs
[here](https://github.com/apache/druid/blob/master/docs/querying/sql-translation.md?plain=1#L447)
and
[here](https://github.com/apache/druid/blob/master/docs/querying/sql-translation.md?plain=1#L668)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
