kgyrtkirk commented on code in PR #15996:
URL: https://github.com/apache/druid/pull/15996#discussion_r1511444000
##########
processing/src/main/java/org/apache/druid/frame/read/columnar/DoubleFrameColumnReader.java:
##########
@@ -67,7 +67,7 @@ public ColumnPlus readColumn(final Frame frame)
return new ColumnPlus(
frameCol,
ColumnCapabilitiesImpl.createSimpleNumericColumnCapabilities(frameCol.getType())
- .setHasNulls(NullHandling.sqlCompatible() &&
frameCol.hasNulls),
Review Comment:
I've taken the second approach:
* restored these classes to the previous state
* added an `assumeTrue(sqlCompatible)` to the testcase
I still think that it might not be a good idea to retain/make tweaks like
this...`null` does exists in the system even when `defaultValue` is
enabled...so it may naturally happen as a value in a column as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
