kgyrtkirk commented on code in PR #15996:
URL: https://github.com/apache/druid/pull/15996#discussion_r1507753367
##########
processing/src/main/java/org/apache/druid/frame/read/columnar/DoubleFrameColumnReader.java:
##########
@@ -67,7 +67,7 @@ public ColumnPlus readColumn(final Frame frame)
return new ColumnPlus(
frameCol,
ColumnCapabilitiesImpl.createSimpleNumericColumnCapabilities(frameCol.getType())
- .setHasNulls(NullHandling.sqlCompatible() &&
frameCol.hasNulls),
Review Comment:
* I think even in case we are defaulting `null`-s to something somewhere; we
may still have the `null` value.
running the following query with druid-27.0.0 with
`druid.generic.useDefaultValueForNull: true`
```
select null,'',0,cast(null as integer)
null | empty | 0 | null
```
which suggests that the column value can be `null`
* in this case the incoming column also reported that it has nulls - I think
it shouldn't be allowed to narrow the scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
