AmatyaAvadhanula commented on code in PR #15726:
URL: https://github.com/apache/druid/pull/15726#discussion_r1512826619
##########
server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java:
##########
@@ -264,8 +267,15 @@ private void cacheInitializedTimedOut()
@GuardedBy("lock")
private void cacheInitialized(boolean timedOut)
{
+ // This method is called only once with either timedOut = true or false,
but not both.
Review Comment:
done
##########
server/src/test/java/org/apache/druid/discovery/BaseNodeRoleWatcherTest.java:
##########
@@ -141,17 +146,18 @@ public void testRegisterListenerBeforeTimeout() throws
InterruptedException
nodeRoleWatcher.childRemoved(broker2);
assertListener(listener1, false, Collections.emptyList(),
Collections.emptyList());
+ Assert.assertFalse(listener1.nodeViewInitializationTimedOut.get());
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
