abhishekagarwal87 commented on code in PR #15726:
URL: https://github.com/apache/druid/pull/15726#discussion_r1513798174
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunnerTest.java:
##########
@@ -1686,7 +1686,7 @@ public void testShutdown()
@Test(timeout = 60_000L)
public void testSyncMonitoring_finiteIteration()
{
- TestDruidNodeDiscovery druidNodeDiscovery = new TestDruidNodeDiscovery();
+ TestDruidNodeDiscovery druidNodeDiscovery = new
TestDruidNodeDiscovery(true);
Review Comment:
lets not change an existing test case like this. It will be confusing to a
reader as to why `timedOut` is set to true in this particular test case. lets
get rid of it entirely or add a new test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
