abhishekagarwal87 commented on code in PR #16047:
URL: https://github.com/apache/druid/pull/16047#discussion_r1514312905
##########
extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleDataSegmentKiller.java:
##########
@@ -70,12 +70,12 @@ public void kill(DataSegment segment) throws
SegmentLoadingException
// anymore, but we still delete them if exists.
deleteIfPresent(bucket, descriptorPath);
}
- catch (IOException e) {
+ catch (StorageException e) {
throw new SegmentLoadingException(e, "Couldn't kill segment[%s]: [%s]",
segment.getId(), e.getMessage());
}
}
- private void deleteIfPresent(String bucket, String path) throws IOException
+ private void deleteIfPresent(String bucket, String path)
{
try {
RetryUtils.retry(
Review Comment:
We need to change that method and also add
```
if (t instanceof StorageException) {
final StorageException s = (StorageException) t;
return s.isRetryable();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
