gargvishesh commented on code in PR #16047:
URL: https://github.com/apache/druid/pull/16047#discussion_r1514513657
##########
extensions-core/google-extensions/src/test/java/org/apache/druid/storage/google/GoogleUtilsTest.java:
##########
@@ -78,5 +79,25 @@ public void test429()
new IOException("generic io exception")
)
);
+ Assert.assertTrue(
+ GoogleUtils.isRetryable(
+ new StorageException(429, "ignored")
+ )
+ );
+ Assert.assertTrue(
+ GoogleUtils.isRetryable(
+ new StorageException(500, "ignored")
+ )
+ );
+ Assert.assertTrue(
+ GoogleUtils.isRetryable(
+ new StorageException(503, "ignored")
+ )
+ );
+ Assert.assertTrue(
Review Comment:
Done
##########
extensions-core/google-extensions/src/test/java/org/apache/druid/storage/google/GoogleStorageTest.java:
##########
@@ -50,6 +51,8 @@ public class GoogleStorageTest
static final String PATH = "/path";
static final long SIZE = 100;
static final OffsetDateTime UPDATE_TIME = OffsetDateTime.MIN;
+ private static final Exception RUNTIME_EXCEPTION = new StorageException(404,
"Runtime Storage Exception");
Review Comment:
Done
##########
extensions-core/google-extensions/src/test/java/org/apache/druid/storage/google/GoogleDataSegmentKillerTest.java:
##########
@@ -99,16 +95,11 @@ public void killTest() throws SegmentLoadingException,
IOException
verifyAll();
}
- @Test(expected = SegmentLoadingException.class)
- public void killWithErrorTest() throws SegmentLoadingException, IOException
+ @Test(expected = RE.class)
Review Comment:
Modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
