georgew5656 commented on code in PR #16065: URL: https://github.com/apache/druid/pull/16065#discussion_r1516349185
########## indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java: ########## @@ -1108,13 +1108,12 @@ private static InputFormat getInputFormat(IndexIngestionSpec ingestionSchema) } @Override - public void cleanUp(TaskToolbox toolbox, @Nullable TaskStatus taskStatus) throws Exception + protected boolean shouldCleanupTask() Review Comment: shouldCleanupTask is used in ParallelIndexSupervisorTask as well. i thought rather than copying the cleanupLogic in IndexTask (check the boolean and call super.cleanup() if true), it would be easier to add a new method that could be implemented, but i think what you say makes sense, i can change it back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
