adithyachakilam commented on code in PR #16065:
URL: https://github.com/apache/druid/pull/16065#discussion_r1515240184
##########
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureStorage.java:
##########
@@ -116,7 +116,7 @@ public void uploadBlockBlob(final File file, final String
containerName, final S
try (FileInputStream stream = new FileInputStream(file)) {
// By default this creates a Block blob, no need to use a specific Block
blob client.
// We also need to urlEncode the path to handle special characters.
-
blobContainerClient.getBlobClient(Utility.urlEncode(blobPath)).upload(stream,
file.length());
+
blobContainerClient.getBlobClient(Utility.urlEncode(blobPath)).upload(stream,
file.length(), true);
Review Comment:
`overwrite=true` is now not required since we would not be. pushing files
multiple times now ?
##########
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureStorage.java:
##########
@@ -116,7 +116,7 @@ public void uploadBlockBlob(final File file, final String
containerName, final S
try (FileInputStream stream = new FileInputStream(file)) {
// By default this creates a Block blob, no need to use a specific Block
blob client.
// We also need to urlEncode the path to handle special characters.
-
blobContainerClient.getBlobClient(Utility.urlEncode(blobPath)).upload(stream,
file.length());
+
blobContainerClient.getBlobClient(Utility.urlEncode(blobPath)).upload(stream,
file.length(), true);
Review Comment:
`overwrite=true` is now not required since we would not be pushing files
multiple times now ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
