kfaraz commented on code in PR #16072:
URL: https://github.com/apache/druid/pull/16072#discussion_r1517081030
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java:
##########
@@ -252,6 +252,25 @@ public Object2IntMap<String>
getDatasourceToUnavailableSegmentCount()
return datasourceToUnavailableSegments;
}
+ public Object2IntMap<String>
getDatasourceToDeepStorageQueryOnlySegmentCount()
Review Comment:
Some of the code in this method can be commoned out with
`getDatasourceToUnavailableSegmentCount`.
##########
docs/operations/metrics.md:
##########
@@ -332,6 +332,7 @@ These metrics are for the Druid Coordinator and are reset
each time the Coordina
|`segment/unneededEternityTombstone/count`|Number of non-overshadowed eternity
tombstones marked as unused.| |Varies|
|`segment/unavailable/count`|Number of unique segments left to load until all
used segments are available for queries.|`dataSource`|0|
|`segment/underReplicated/count`|Number of segments, including replicas, left
to load until all used segments are available for queries.|`tier`,
`dataSource`|0|
+|`segment/deepStorageOnly/count`|Number of unique segments that are only
available for querying directly from deep storage.|`dataSource`|Varies|
Review Comment:
How about the metric name `deepStorageQueryOnly` or better yet
`availableDeepStorageOnly` as it aligns better with `unavailable/count`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
