gianm commented on code in PR #15974:
URL: https://github.com/apache/druid/pull/15974#discussion_r1517177947
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/MultiValueStringOperatorConversions.java:
##########
@@ -458,6 +578,28 @@ boolean isAllowList()
}
}
+
+ private static List<DruidExpression>
harmonizeNullsMvdArg0OperandList(List<DruidExpression> druidExpressions)
+ {
+ final List<DruidExpression> newArgs;
+ if (druidExpressions.get(0).isDirectColumnAccess()) {
Review Comment:
> So... I guess we can apply it all the time, i'll need to update some other
tests, especially some of the tests i have with array columns which are
wrapping the array columns with `ARRAY_TO_MV` and then testing the `MV_`
functions, who do correctly distinguish between `null`, `[]` and `[null]` but
now would no longer at least when using with these functions.
How do you define "correctly" in this sentence? I would think that if you
apply `ARRAY_TO_MV`, it's more correct to harmonize the arrays than to not
harmonize them. That makes them behave more like they would if they had been
ingested as MVDs, which I think is the point of `ARRAY_TO_MV`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
