kfaraz commented on code in PR #16083:
URL: https://github.com/apache/druid/pull/16083#discussion_r1517484572
##########
extensions-core/google-extensions/src/test/java/org/apache/druid/storage/google/GoogleStorageTest.java:
##########
@@ -159,7 +160,33 @@ public void testGetMetadata() throws IOException
EasyMock.replay(mockStorage, blob);
GoogleStorageObjectMetadata objectMetadata =
googleStorage.getMetadata(BUCKET, PATH);
- assertEquals(objectMetadata, new GoogleStorageObjectMetadata(BUCKET, PATH,
SIZE, UPDATE_TIME.toEpochSecond()));
+ assertEquals(
+ objectMetadata,
+ new GoogleStorageObjectMetadata(BUCKET, PATH, SIZE,
UPDATE_TIME.toEpochSecond() * 1000)
+ );
+
+ }
+ @Test
+ public void testGetMetadataMismatch() throws IOException
Review Comment:
Oh, I think it is the same as the above test `testGetMetadataMismatch()` but
verifies that the timestamp is __not in seconds__ .
@gargvishesh , I think the previous test `testGetMetadata()` is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
