kfaraz commented on code in PR #16083:
URL: https://github.com/apache/druid/pull/16083#discussion_r1517347552
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/duty/TaskLogAutoCleanerConfig.java:
##########
@@ -43,18 +43,18 @@ public class TaskLogAutoCleanerConfig
private final long delay;
@JsonProperty
- private final long durationToRetain;
+ private final long durationToRetainMs;
@JsonCreator
public TaskLogAutoCleanerConfig(
@JsonProperty("enabled") boolean enabled,
@JsonProperty("initialDelay") Long initialDelay,
@JsonProperty("delay") Long delay,
- @JsonProperty("durationToRetain") Long durationToRetain
+ @JsonProperty("durationToRetain") Long durationToRetainMs
Review Comment:
If this is being changed, other fields such as `initialDelay`, `delay`
should be changed too.
I think it is okay to keep it the way it is as the name `durationToRetain`
is being used in several other configs too. You could add javadocs to clarify
the usage though.
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/duty/TaskLogAutoCleanerConfig.java:
##########
@@ -43,18 +43,18 @@ public class TaskLogAutoCleanerConfig
private final long delay;
@JsonProperty
- private final long durationToRetain;
+ private final long durationToRetainMs;
@JsonCreator
public TaskLogAutoCleanerConfig(
@JsonProperty("enabled") boolean enabled,
@JsonProperty("initialDelay") Long initialDelay,
@JsonProperty("delay") Long delay,
- @JsonProperty("durationToRetain") Long durationToRetain
+ @JsonProperty("durationToRetain") Long durationToRetainMs
Review Comment:
If this is being changed, other fields such as `initialDelay`, `delay`
should be changed too.
So I think it is okay to keep it the way it is as the name
`durationToRetain` is being used in several other configs too. You could add
javadocs to clarify the usage though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
