kfaraz commented on code in PR #16092:
URL: https://github.com/apache/druid/pull/16092#discussion_r1518787635


##########
services/src/test/java/org/apache/druid/server/AsyncQueryForwardingServletTest.java:
##########
@@ -1063,4 +963,34 @@ public int getPort()
       return port;
     }
   }
+  interface ServletTestAction {
+    void execute(AsyncQueryForwardingServlet servlet, HttpServletRequest 
request, HttpServletResponse response, ObjectMapper mapper) throws Exception;

Review Comment:
   ```suggestion
       
       void execute(AsyncQueryForwardingServlet servlet, HttpServletRequest 
request, HttpServletResponse response, ObjectMapper mapper) throws Exception;
   ```



##########
services/src/test/java/org/apache/druid/server/AsyncQueryForwardingServletTest.java:
##########
@@ -1063,4 +963,34 @@ public int getPort()
       return port;
     }
   }
+  interface ServletTestAction {

Review Comment:
   ```suggestion
     
     interface ServletTestAction {
   ```



##########
services/src/test/java/org/apache/druid/server/AsyncQueryForwardingServletTest.java:
##########
@@ -1063,4 +963,34 @@ public int getPort()
       return port;
     }
   }
+  interface ServletTestAction {
+    void execute(AsyncQueryForwardingServlet servlet, HttpServletRequest 
request, HttpServletResponse response, ObjectMapper mapper) throws Exception;
+  }
+  private ArgumentCaptor<Exception> 
captureExceptionHandledByServlet(ServerConfig serverConfig, ServletTestAction 
action) throws Exception

Review Comment:
   ```suggestion
     
     private ArgumentCaptor<Exception> 
captureExceptionHandledByServlet(ServerConfig serverConfig, ServletTestAction 
action) throws Exception
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to