kgyrtkirk commented on code in PR #16046: URL: https://github.com/apache/druid/pull/16046#discussion_r1519268656
########## sql/src/test/java/org/apache/druid/sql/calcite/BaseCalciteQueryTest.java: ########## @@ -295,15 +298,11 @@ public static Map<String, Object> getTimeseriesContextWithFloorTime( public final SqlEngine engine0; final boolean useDefault = NullHandling.replaceWithDefault(); - @Rule(order = 1) - public ExpectedException expectedException = ExpectedException.none(); - @Rule(order = 2) Review Comment: I agree that these could be changed; however one of the followup changes is to upgrade calcite* tests to junit5 - can we postpone this cleanup to that patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
