kfaraz commented on code in PR #15994:
URL: https://github.com/apache/druid/pull/15994#discussion_r1519609784
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/actions/RetrieveSegmentsActionsTest.java:
##########
@@ -98,31 +102,37 @@ public void testRetrieveUsedSegmentsAction()
{
final RetrieveUsedSegmentsAction action =
new RetrieveUsedSegmentsAction(task.getDataSource(),
ImmutableList.of(INTERVAL));
- final Set<DataSegment> resultSegments = new HashSet<>(action.perform(task,
actionTestKit.getTaskActionToolbox()));
- Assert.assertEquals(expectedUsedSegments, resultSegments);
+ final Set<DataSegment> actualSegments = new HashSet<>(action.perform(task,
actionTestKit.getTaskActionToolbox()));
Review Comment:
Suggestion: I typically use nomenclature of `expected` vs `observed`, e.g.
`observedUsedSegments`.
##########
server/src/main/java/org/apache/druid/client/indexing/ClientKillUnusedSegmentsTaskQuery.java:
##########
@@ -40,6 +41,7 @@ public class ClientKillUnusedSegmentsTaskQuery implements
ClientTaskQuery
private final String id;
private final String dataSource;
private final Interval interval;
+ @Nullable private final List<String> versions;
Review Comment:
```suggestion
@Nullable
private final List<String> versions;
```
##########
server/src/main/java/org/apache/druid/client/indexing/ClientKillUnusedSegmentsTaskQuery.java:
##########
@@ -50,6 +52,7 @@ public ClientKillUnusedSegmentsTaskQuery(
@JsonProperty("id") String id,
@JsonProperty("dataSource") String dataSource,
@JsonProperty("interval") Interval interval,
+ @JsonProperty("versions") List<String> versions,
Review Comment:
```suggestion
@JsonProperty("versions") @Nullable List<String> versions,
```
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUnusedSegmentsAction.java:
##########
@@ -40,6 +40,9 @@ public class RetrieveUnusedSegmentsAction implements
TaskAction<List<DataSegment
@JsonIgnore
private final Interval interval;
+ @JsonIgnore
Review Comment:
So, you plan to remove the `@JsonIgnore` from here too, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
