somu-imply commented on code in PR #15939:
URL: https://github.com/apache/druid/pull/15939#discussion_r1519989478
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -15336,4 +15336,34 @@ public void testFilterParseLongNullable()
ImmutableList.of(new Object[]{NullHandling.sqlCompatible() ? 4L : 0L})
);
}
+
+ @Test
+ public void testLatestByAggregatorOnSecondaryTimestampGroupBy()
Review Comment:
The codepath that has the bug is the `aggregate` of the factory which would
also be called by the `combiningFactory` of the aggregator. In the test case
that is added here, without pushing down the null check, the results would have
been all nulls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
