clintropolis commented on code in PR #15939:
URL: https://github.com/apache/druid/pull/15939#discussion_r1520376162
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -15336,4 +15336,34 @@ public void testFilterParseLongNullable()
ImmutableList.of(new Object[]{NullHandling.sqlCompatible() ? 4L : 0L})
);
}
+
+ @Test
+ public void testLatestByAggregatorOnSecondaryTimestampGroupBy()
Review Comment:
while it doesn't go through combining factory at query time, it still ends
up testing the right scenario because this query goes through group by merge
query runner which runs on the result rows (row adapter) where the value
selector there gets the pairs and time selector is nil because the referenced
column isn't present at that point, so its probably ok. A test in the native
layer probably would have been a bit clearer, but at least this provides some
coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
