abhishekrb19 opened a new pull request, #16129: URL: https://github.com/apache/druid/pull/16129
Summary of changes in this patch by file: #### Changes in `TestDerbyConnector`: - Introduce a helper method `updateSegmentsTable()` that tests can use to execute `UPDATE`, `INSERT`, or DDL commands like `ALTER TABLE`. - Clean up references in tests to use the `updateSegmentsTable()` method where applicable. For example, see usages in `SqlSegmentsMetadataManagerTest`, `IndexerSQLMetadataStorageCoordinatorTest`, `SQLMetadataConnectorTest`. #### Changes in `KillUnusedSegmentsTaskTest`: - Move common segment creation to `setup()` method. - Replace usages of `Thread.sleep()` with calls to the new `updateSegmentsTable()` method. - Miscellaneous indentation adjustments based on review feedback from https://github.com/apache/druid/pull/15994. #### Change in `IndexerSQLMetadataStorageCoordinator`: - Refactor some code in favor of the `verifySegmentsToCommit()` method. This PR has: - [x] been self-reviewed. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
