kfaraz commented on code in PR #16129:
URL: https://github.com/apache/druid/pull/16129#discussion_r1525755356
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTaskTest.java:
##########
@@ -1197,4 +1173,13 @@ private static DataSegment newSegment(Interval interval,
String version, Map<Str
10L
);
}
+
+ private void updateUsedStatusLastUpdated(DataSegment segment, DateTime
newValue)
Review Comment:
Only place I can think is `TestDerbyConnector` itself, or a wrapper around
it.
I would prefer a wrapper as `TestDerbyConnector` itself is completely
agnostic to any column or table names and it is clean that way.
If you do end up writing a wrapper, may be the new `updateSegmentsTable`
should also live there then.
**Edit:**
The wrapper class can be invoked via `TestDerbyConnector` itself so that any
test using `TestDerbyConnector` maybe able to use it without having to
explicitly declare the wrapper. So something like the following.
```java
derbyConnector.segments().update("ALTER TABLE ....");
derbyConnector.segments().updateUsedStatusLastUpdated(segmentId, date);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
