abhishekrb19 commented on code in PR #16129:
URL: https://github.com/apache/druid/pull/16129#discussion_r1526435461
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTaskTest.java:
##########
@@ -166,16 +164,19 @@ public void testKillWithMarkUnused() throws Exception
null
);
-
Assert.assertEquals(ImmutableList.of(newSegment(Intervals.of("2019-02-01/2019-03-01"),
version)), unusedSegments);
+ Assert.assertEquals(ImmutableList.of(segment2), unusedSegments);
Assertions.assertThat(
- getMetadataStorageCoordinator()
- .retrieveUsedSegmentsForInterval(DATA_SOURCE,
Intervals.of("2019/2020"), Segments.ONLY_VISIBLE)
- ).containsExactlyInAnyOrder(
- newSegment(Intervals.of("2019-01-01/2019-02-01"), version),
- newSegment(Intervals.of("2019-04-01/2019-05-01"), version)
- );
+ getMetadataStorageCoordinator().retrieveUsedSegmentsForInterval(
+ DATA_SOURCE,
+ Intervals.of("2019/2020"),
+ Segments.ONLY_VISIBLE
+ )
+ ).containsExactlyInAnyOrder(segment1, segment4);
- Assert.assertEquals(new KillTaskReport.Stats(1, 2, 1), getReportedStats());
Review Comment:
Yeah, it doesn't seem like much when looking at this line, but with the IDE
providing parameter hints, things seem longer than they appear in a split
screen setting. So I often end up scrolling right through the screen and the
line break helps with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
