cryptoe commented on code in PR #16003:
URL: https://github.com/apache/druid/pull/16003#discussion_r1529779685
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteJoinQueryTest.java:
##########
@@ -3826,13 +3826,16 @@ public void
testJoinWithExplicitIsNotDistinctFromCondition(Map<String, Object> q
.context(queryContext)
.build()
),
- ImmutableList.of(
- new Object[]{"", ""},
- new Object[]{"10.1", "10.1"},
- new Object[]{"2", "2"},
- new Object[]{"1", "1"},
- new Object[]{"def", "def"},
- new Object[]{"abc", "abc"}
+ sortIfSortBased(
+ ImmutableList.of(
+ new Object[]{"", ""},
+ new Object[]{"10.1", "10.1"},
+ new Object[]{"2", "2"},
+ new Object[]{"1", "1"},
+ new Object[]{"def", "def"},
+ new Object[]{"abc", "abc"}
+ ),
+ 0
)
);
}
Review Comment:
I was hoping to find a UT test case with is `not distinct from` sql query
with sort merge enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
