gianm commented on code in PR #16003:
URL: https://github.com/apache/druid/pull/16003#discussion_r1529808059
##########
processing/src/main/java/org/apache/druid/frame/key/FrameComparisonWidgetImpl.java:
##########
@@ -138,21 +139,29 @@ public RowKey readKey(int row)
}
@Override
- public boolean isCompletelyNonNullKey(int row)
+ public boolean hasNonNullKeyParts(int row, int[] keyParts)
{
- if (keyFieldCount == 0) {
+ if (keyParts.length == 0) {
return true;
}
Review Comment:
It does allow us to skip calling `getRowPositionInDataRegion`, which I
thought might be useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
