jakubmatyszewski commented on code in PR #16109:
URL: https://github.com/apache/druid/pull/16109#discussion_r1534768643
##########
extensions-core/druid-pac4j/src/main/java/org/apache/druid/security/pac4j/Pac4jFilter.java:
##########
@@ -96,24 +97,24 @@ public void doFilter(ServletRequest servletRequest,
ServletResponse servletRespo
"/",
true, false, false, null);
} else {
- Object uid = securityLogic.perform(
+ OidcProfile profile = (OidcProfile) securityLogic.perform(
Review Comment:
I'm not certain, I don't know java, but I think it's useful in here - since
we use OIDC config here, the `UserProfiles` should always be complient with
`OidcProfile` anyway. And later `OidcProfile` is more convenient to pass the
context - `UserProfile` doesn't have explicit function to return all attributes
at once, which is the goal here.
I'm eager to learn if what I've wrote is not correct, let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
