abhishekagarwal87 commented on code in PR #16109:
URL: https://github.com/apache/druid/pull/16109#discussion_r1535256072
##########
extensions-core/druid-pac4j/src/main/java/org/apache/druid/security/pac4j/Pac4jFilter.java:
##########
@@ -96,24 +97,24 @@ public void doFilter(ServletRequest servletRequest,
ServletResponse servletRespo
"/",
true, false, false, null);
} else {
- Object uid = securityLogic.perform(
+ OidcProfile profile = (OidcProfile) securityLogic.perform(
Review Comment:
`profiles.iterator().next()` is returning `UserProfile` which is an
interface. I was thinking that you use that but it doesn't have `getAttributes`
method. But now I am wondering why not pass the whole profile itself.
```
AuthenticationResult authenticationResult = new
AuthenticationResult(profile.getId(), authorizerName, name,
ImmutableMap.of("profile", profile))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
