kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546067491
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ########## @@ -1715,9 +1726,109 @@ private void publishSegmentsIfNeeded( //noinspection unchecked @SuppressWarnings("unchecked") final Set<DataSegment> segments = (Set<DataSegment>) queryKernel.getResultObjectForStage(finalStageId); + + Function<Set<DataSegment>, Set<DataSegment>> compactionStateAnnotateFunction = Function.identity(); Review Comment: Rather than declaring this function outside the if-else and assigning `identity()` to it, it should just be declared where necessary. You can make the `segments` non-final. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org