gargvishesh commented on PR #15965: URL: https://github.com/apache/druid/pull/15965#issuecomment-2031140076
@cryptoe @kfaraz Tested it on local cluster. Storing compaction state and triggering compaction only if states differ are working as expected. However, the defaults for DynamicPartitionsSpec weren't matching with those used by compaction. I've changed the spec creation from using `DynamicPartitionsSpec(task.getQuerySpec().getTuningConfig().getRowsPerSegment(), null)` to `DynamicPartitionsSpec(null, DynamicPartitionsSpec.DEFAULT_COMPACTION_MAX_TOTAL_ROWS)`. The original `task.getQuerySpec().getTuningConfig().getRowsPerSegment()` uses 3M by default and is meant to be target #rows whereas default `maxRowsPerSegment` used by `DynamicPartitionsSpec` is 5M. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
