LakshSingla commented on code in PR #15420:
URL: https://github.com/apache/druid/pull/15420#discussion_r1547144457
##########
processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryQueryToolChest.java:
##########
@@ -102,35 +104,53 @@ public class GroupByQueryQueryToolChest extends
QueryToolChest<ResultRow, GroupB
private final GroupingEngine groupingEngine;
private final GroupByQueryConfig queryConfig;
private final GroupByQueryMetricsFactory queryMetricsFactory;
+ private final GroupByResourcesReservationPool
groupByResourcesReservationPool;
@VisibleForTesting
- public GroupByQueryQueryToolChest(GroupingEngine groupingEngine)
+ public GroupByQueryQueryToolChest(
+ GroupingEngine groupingEngine,
+ GroupByResourcesReservationPool groupByResourcesReservationPool
+ )
{
- this(groupingEngine, GroupByQueryConfig::new,
DefaultGroupByQueryMetricsFactory.instance());
+ this(
+ groupingEngine,
+ GroupByQueryConfig::new,
+ DefaultGroupByQueryMetricsFactory.instance(),
+ groupByResourcesReservationPool
+ );
}
@Inject
public GroupByQueryQueryToolChest(
GroupingEngine groupingEngine,
Supplier<GroupByQueryConfig> queryConfigSupplier,
- GroupByQueryMetricsFactory queryMetricsFactory
+ GroupByQueryMetricsFactory queryMetricsFactory,
+ @Merging GroupByResourcesReservationPool groupByResourcesReservationPool
Review Comment:
True, I reasoned that `@Merging` was used to annotate the global resources
associated with the group by merging therefore I annotated the resource pool
with that, and it doesn't have any functional relevance. I am fine with
removing it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
