kfaraz commented on code in PR #15965:
URL: https://github.com/apache/druid/pull/15965#discussion_r1553532394
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQReplaceTest.java:
##########
@@ -948,6 +1053,68 @@
new Object[]{978480000000L, 6.0f}
)
)
+ .setExpectedLastCompactionState(
+ expectedCompactionState(
+ context, Collections.emptyList(),
+ Collections.singletonList(new
FloatDimensionSchema("m1")),
+ GranularityType.ALL
+ )
+ )
+ .verifyResults();
+ }
+
+ @MethodSource("data")
+ @ParameterizedTest(name = "{index}:with context {0}")
+ public void testReplaceSegmentsWithQuarterSegmentGranularity(String
contextName, Map<String, Object> context)
Review Comment:
I see, thanks for the clarification. The second parameter is used just to
name the test in JUnit. There also seems to be a lot of repetition of the
annotations.
Edit: Apparently this is the just the way JUnit5 works. There is no way
(yet) to parameterize the constructor of the entire test class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
