gianm commented on code in PR #16262:
URL: https://github.com/apache/druid/pull/16262#discussion_r1560403098
##########
processing/src/main/java/org/apache/druid/java/util/metrics/JvmMonitor.java:
##########
@@ -40,12 +40,12 @@
public class JvmMonitor extends FeedDefiningMonitor
{
- private final Map<String, String[]> dimensions;
-
+ private static final String JVM_VERSION = "jvmVersion";
+ private static final String JAVA_VERSION =
System.getProperty("java.version");
Review Comment:
What do these strings typically look like? Just wanting to make sure the
thing we are emitting is useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
