pranavbhole commented on code in PR #16262:
URL: https://github.com/apache/druid/pull/16262#discussion_r1560409324
##########
processing/src/main/java/org/apache/druid/java/util/metrics/JvmMonitor.java:
##########
@@ -40,12 +40,12 @@
public class JvmMonitor extends FeedDefiningMonitor
{
- private final Map<String, String[]> dimensions;
-
+ private static final String JVM_VERSION = "jvmVersion";
+ private static final String JAVA_VERSION =
System.getProperty("java.version");
Review Comment:
here's the typical output of System.getProperty("java.version") for each
major Java version:
Java 1.0 - 1.1: These versions didn't have a specific format for
java.version. They often returned something like "1.0" or "1.1".
Java 1.2 - 1.4: These versions commonly returned versions like "1.2.2",
"1.3.1", or "1.4.2".
Java 5 (1.5): Typically, you'd see versions like "1.5.0_22".
Java 6 (1.6): Commonly returned something like "1.6.0_45".
Java 7 (1.7): Versions often looked like "1.7.0_80".
Java 8 (1.8): Frequently returned versions such as "1.8.0_291".
Java 9 (9): Introduced the new versioning scheme, so you'd see something
like "9.0.4".
Java 10: Versions would be like "10.0.1".
Java 11: You'd typically see versions like "11.0.11".
Java 12: Versions could look like "12.0.2".
Java 13: Versions might be something like "13.0.2".
Java 14: Versions could look like "14.0.1".
Java 15: Versions might be like "15.0.1".
Java 16: Versions could look like "16.0.1".
Java 17: Versions might be like "17".
Java 18: Versions might be like "18".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
