kfaraz commented on code in PR #16144:
URL: https://github.com/apache/druid/pull/16144#discussion_r1567053889
##########
server/src/main/java/org/apache/druid/metadata/PendingSegmentRecord.java:
##########
@@ -33,11 +33,14 @@
/**
* Representation of a record in the pending segments table. <br/>
* Mapping of column in table to field:
- * <li/> id -> id (Unique identifier for pending segment)
- * <li/> sequence_name -> sequenceName (sequence name used for segment
allocation)
- * <li/> sequence_prev_id -> sequencePrevId (previous segment id used for
segment allocation)
- * <li/> upgraded_from_segment_id -> upgradedFromSegmentId (Id of the root
segment from which this was upgraded)
- * <li/> task_allocator_id -> taskAllocatorId (Associates a task / task group
/ replica group with the pending segment)
+ *
+ * <ul>
+ * <li> id -> id (Unique identifier for pending segment) <li/>
+ * <li> sequence_name -> sequenceName (sequence name used for segment
allocation) <li/>
+ * <li> sequence_prev_id -> sequencePrevId (previous segment id used for
segment allocation) <li/>
+ * <li> upgraded_from_segment_id -> upgradedFromSegmentId (Id of the root
segment from which this was upgraded) <li/>
+ * <li> task_allocator_id -> taskAllocatorId (Associates a task / task group
/ replica group with the pending segment) <li/>
Review Comment:
This list is not needed here, the description of the fields should be in the
javadocs of the respective getters.
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -213,6 +220,16 @@ public int compare(Pair<Task, TaskLock> left, Pair<Task,
TaskLock> right)
activeTasks.remove(task.getId());
}
}
+ activePendingTaskGroupToTaskIds.clear();
+ for (Task task : storedActiveTasks) {
Review Comment:
Sorry, missed that. Thanks for the clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
