AmatyaAvadhanula commented on code in PR #16144:
URL: https://github.com/apache/druid/pull/16144#discussion_r1566989854


##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -213,6 +220,16 @@ public int compare(Pair<Task, TaskLock> left, Pair<Task, 
TaskLock> right)
           activeTasks.remove(task.getId());
         }
       }
+      activePendingTaskGroupToTaskIds.clear();
+      for (Task task : storedActiveTasks) {

Review Comment:
   The first iteration removes entries from the `activeTasks` collection while 
the second loop ensures that it processes only those tasks in activeTasks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to