kfaraz commented on code in PR #15705:
URL: https://github.com/apache/druid/pull/15705#discussion_r1571802160
##########
server/src/test/java/org/apache/druid/server/coordinator/duty/KillSupervisorsTest.java:
##########
@@ -56,73 +56,21 @@ public void setup()
@Test
public void testRunSkipIfLastRunLessThanPeriod()
{
- TestDruidCoordinatorConfig druidCoordinatorConfig = new
TestDruidCoordinatorConfig.Builder()
- .withMetadataStoreManagementPeriod(new Duration("PT5S"))
- .withCoordinatorSupervisorKillPeriod(new Duration(Long.MAX_VALUE))
- .withCoordinatorSupervisorKillDurationToRetain(new Duration("PT1S"))
- .withCoordinatorKillMaxSegments(10)
- .withCoordinatorKillIgnoreDurationToRetain(false)
- .build();
- killSupervisors = new KillSupervisors(druidCoordinatorConfig,
mockMetadataSupervisorManager);
+ final MetadataCleanupConfig config
+ = new MetadataCleanupConfig(true, new Duration(Long.MAX_VALUE), new
Duration("PT1S"));
+ killSupervisors = new KillSupervisors(config,
mockMetadataSupervisorManager);
killSupervisors.run(mockDruidCoordinatorRuntimeParams);
Mockito.verifyNoInteractions(mockMetadataSupervisorManager);
}
@Test
public void testRunNotSkipIfLastRunMoreThanPeriod()
{
- TestDruidCoordinatorConfig druidCoordinatorConfig = new
TestDruidCoordinatorConfig.Builder()
- .withMetadataStoreManagementPeriod(new Duration("PT5S"))
- .withCoordinatorSupervisorKillPeriod(new Duration("PT6S"))
- .withCoordinatorSupervisorKillDurationToRetain(new Duration("PT1S"))
- .withCoordinatorKillMaxSegments(10)
- .withCoordinatorKillIgnoreDurationToRetain(false)
- .build();
- killSupervisors = new KillSupervisors(druidCoordinatorConfig,
mockMetadataSupervisorManager);
+ final MetadataCleanupConfig config
+ = new MetadataCleanupConfig(true, new Duration("PT6S"), new
Duration("PT1S"));
+ killSupervisors = new KillSupervisors(config,
mockMetadataSupervisorManager);
killSupervisors.run(mockDruidCoordinatorRuntimeParams);
Mockito.verify(mockMetadataSupervisorManager).removeTerminatedSupervisorsOlderThan(ArgumentMatchers.anyLong());
Assert.assertTrue(runStats.hasStat(Stats.Kill.SUPERVISOR_SPECS));
}
-
- @Test
- public void testConstructorFailIfInvalidPeriod()
Review Comment:
These tests have been moved to `DruidCoordinatorConfigTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
