kfaraz commented on code in PR #15705:
URL: https://github.com/apache/druid/pull/15705#discussion_r1577177257
##########
server/src/main/java/org/apache/druid/server/coordinator/duty/KillUnusedSegments.java:
##########
@@ -90,44 +88,25 @@ public class KillUnusedSegments implements CoordinatorDuty
private final OverlordClient overlordClient;
public KillUnusedSegments(
- final SegmentsMetadataManager segmentsMetadataManager,
- final OverlordClient overlordClient,
- final DruidCoordinatorConfig config
+ SegmentsMetadataManager segmentsMetadataManager,
+ OverlordClient overlordClient,
+ KillUnusedSegmentsConfig killConfig
)
{
- if (config.getCoordinatorKillPeriod().getMillis() <
config.getCoordinatorIndexingPeriod().getMillis()) {
- throw DruidException.forPersona(DruidException.Persona.OPERATOR)
- .ofCategory(DruidException.Category.INVALID_INPUT)
- .build(
- StringUtils.format(
- "druid.coordinator.kill.period[%s] is
invalid. It must be greater than or "
- + "equal to
druid.coordinator.period.indexingPeriod[%s].",
- config.getCoordinatorKillPeriod(),
- config.getCoordinatorIndexingPeriod()
- )
- );
- }
- if (config.getCoordinatorKillMaxSegments() < 0) {
- throw DruidException.forPersona(DruidException.Persona.OPERATOR)
- .ofCategory(DruidException.Category.INVALID_INPUT)
- .build(StringUtils.format(
- "druid.coordinator.kill.maxSegments[%d]
is invalid. It must be a positive integer.",
- config.getCoordinatorKillMaxSegments()
- )
- );
- }
- this.period = config.getCoordinatorKillPeriod();
- this.ignoreDurationToRetain =
config.getCoordinatorKillIgnoreDurationToRetain();
- this.durationToRetain = config.getCoordinatorKillDurationToRetain();
+ this.period = killConfig.getCleanupPeriod();
+
+ this.maxSegmentsToKill = killConfig.getMaxSegments();
+ this.ignoreDurationToRetain = killConfig.isIgnoreDurationToRetain();
+ this.durationToRetain = killConfig.getDurationToRetain();
if (this.ignoreDurationToRetain) {
log.info(
"druid.coordinator.kill.durationToRetain[%s] will be ignored when
discovering segments to kill "
+ "because druid.coordinator.kill.ignoreDurationToRetain is set to
true.",
- this.durationToRetain
+ durationToRetain
);
}
- this.bufferPeriod = config.getCoordinatorKillBufferPeriod().getMillis();
- this.maxSegmentsToKill = config.getCoordinatorKillMaxSegments();
+ this.bufferPeriod = killConfig.getBufferPeriod().getMillis();
Review Comment:
Done.
##########
server/src/main/java/org/apache/druid/server/coordinator/duty/KillSupervisorsCustomDuty.java:
##########
@@ -38,43 +37,32 @@
* <p>
* This duty is only an example to demostrate the usage of coordinator custom
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
